apollo_storage: invoke backward compitability

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-25T14:48:21Z
• Started at 2026-01-25T14:48:55Z
• Started at 2026-01-25T15:08:44Z
• Started at 2026-01-25T15:23:40Z
• Started at 2026-01-25T15:28:11Z
• Started at 2026-01-28T11:16:55Z
• Started at 2026-01-29T09:34:18Z
• Started at 2026-01-29T10:49:03Z
• Started at 2026-02-01T10:03:16Z

[avivg-starkware]

• apollo_storage: invoke backward compitability #11952 👈 (View in Graphite)
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avivg-starkware]

crates/apollo_storage/src/serialization/serializers.rs line 1282 at r1 (raw file):

    // NOTE: InvokeTransactionV3 has a custom StorageSerde impl below for backward compatibility
    // (handling transactions stored before the proof_facts field was added)

Not sure whether it's better with or without that here

Code quote:

    // NOTE: InvokeTransactionV3 has a custom StorageSerde impl below for backward compatibility
    // (handling transactions stored before the proof_facts field was added)

[avivg-starkware]

crates/apollo_storage/src/serialization/serializers.rs line 1373 at r2 (raw file):

    }

    fn deserialize_from(bytes: &mut impl std::io::Read) -> Option<Self> {

@ShahakShama - this PR is only relevant if we need to read previously saved txs. Do you know if we ever try reading those? If not, perhaps we don't need this PR

[dan-starkware]

@dan-starkware made 3 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @ShahakShama).

---

a discussion (no related file):
Consider fixing typo in commit message (compitability)

---

crates/apollo_storage/src/serialization/serializers.rs line 1340 at r2 (raw file):

// NOTE: This is a temporary migration shim. Once all nodes have re-synced (i.e., no stored
// transactions exist in the old format), remove this impl and move InvokeTransactionV3 back
// to `auto_storage_serde_conditionally_compressed!`.

Add corresponding TODO

Code quote:

// NOTE: This is a temporary migration shim. Once all nodes have re-synced (i.e., no stored
// transactions exist in the old format), remove this impl and move InvokeTransactionV3 back
// to `auto_storage_serde_conditionally_compressed!`.

---

crates/apollo_storage/src/serialization/serializers.rs line 1394 at r2 (raw file):

        // Backward compatibility: proof_facts may not exist in old transactions.
        // If there's no more data, default to empty ProofFacts.
        let proof_facts = ProofFacts::deserialize_from(data).unwrap_or_default();

This will silently default to empty ProofFacts if deserialization fails for ANY reason, including corrupted data.
In general, a safer approach would be to only default on empty data (legacy format) and propagate actual errors.
For a "temporary migration shim" I think unwrap_or_default() approach is pragmatic and fine for this case.

[avivg-starkware]

@avivg-starkware made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @noaov1 and @ShahakShama).

---

crates/apollo_storage/src/serialization/serializers.rs line 1340 at r2 (raw file):

Previously, dan-starkware wrote…

Add corresponding TODO

Added

---

crates/apollo_storage/src/serialization/serializers.rs line 1394 at r2 (raw file):

Previously, dan-starkware wrote…

This will silently default to empty ProofFacts if deserialization fails for ANY reason, including corrupted data.
In general, a safer approach would be to only default on empty data (legacy format) and propagate actual errors.
For a "temporary migration shim" I think unwrap_or_default() approach is pragmatic and fine for this case.

Thanks! I updated this so we only default when no data remains, allowing other deserialization errors to be surfaced.

[avivg-starkware]

@avivg-starkware resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @ShahakShama).

[noaov1]

@noaov1 reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama).

[avivg-starkware]

@avivg-starkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama).