Skip to content

blockifier: add get execution info v2 to get execution test #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meship-starkware merged 1 commit into from
Jan 27, 2026
Merged

blockifier: add get execution info v2 to get execution test #11410

meship-starkware merged 1 commit into from
Jan 27, 2026

Conversation

@meship-starkware
Copy link
Collaborator

@meship-starkware meship-starkware commented Jan 5, 2026

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jan 5, 2026

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 5, 2026 •
edited
Loading

Artifacts upload workflows:

@meship-starkware meship-starkware marked this pull request as ready for review January 5, 2026 08:41
@meship-starkware Graphite App
Copy link
Collaborator Author

meship-starkware commented Jan 5, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

meship-starkware
meship-starkware commented Jan 5, 2026
View reviewed changes
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 527 at r1 (raw file):

    true,
    "test_get_execution_info_v2";
    "V2: Exclude l1 data gas: query")]

I am not sure about adding all the test cases for v2 as well. Perhaps we should focus only on the commonly used cases.

Code quote:

// V2 entry point test cases (using test_get_execution_info_v2).
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Validate,
        TransactionVersion::THREE,
        false,
        false,
        false,
        false,
        "test_get_execution_info_v2";
        "Native V2: Validate execution mode: block info fields should be zeroed. Transaction V3."
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        false,
        false,
        false,
        false,
        "test_get_execution_info_v2";
        "Native V2: Execute execution mode: block info should be as usual. Transaction V3."
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        true,
        false,
        false,
        false,
        "test_get_execution_info_v2";
        "Native V2: Execute execution mode: block info should be as usual. Transaction V3. Query"
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        false,
        true,
        false,
        false,
        "test_get_execution_info_v2";
        "Native V2: V1 bound account: execute"
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        true,
        true,
        false,
        false,
        "test_get_execution_info_v2";
        "Native V2: V1 bound account: query"
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        true,
        false,
        false,
        true,
        "test_get_execution_info_v2";
        "Native V2: data gas account: query"
    )
)]
#[cfg_attr(
    feature = "cairo_native",
    test_case(
        FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Native)),
        ExecutionMode::Execute,
        TransactionVersion::THREE,
        false,
        false,
        false,
        true,
        "test_get_execution_info_v2";
        "Native V2: data gas account"
    )
)]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Validate,
    TransactionVersion::ONE,
    false,
    false,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: Validate execution mode: block info fields should be zeroed. Transaction V1.")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::ONE,
    false,
    false,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: Execute execution mode: block info should be as usual. Transaction V1.")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Validate,
    TransactionVersion::THREE,
    false,
    false,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: Validate execution mode: block info fields should be zeroed. Transaction V3.")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    false,
    false,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: Execute execution mode: block info should be as usual. Transaction V3.")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    true,
    false,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: Execute execution mode: block info should be as usual. Transaction V3. Query.")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    false,
    true,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: V1 bound account: execute")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    false,
    true,
    true,
    false,
    "test_get_execution_info_v2";
    "V2: V1 bound account: execute, high tip")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    true,
    true,
    false,
    false,
    "test_get_execution_info_v2";
    "V2: V1 bound account: query")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    false,
    false,
    false,
    true,
    "test_get_execution_info_v2";
    "V2: Exclude l1 data gas: execute")]
#[test_case(
    FeatureContract::TestContract(CairoVersion::Cairo1(RunnableCairo1::Casm)),
    ExecutionMode::Execute,
    TransactionVersion::THREE,
    true,
    false,
    false,
    true,
    "test_get_execution_info_v2";
    "V2: Exclude l1 data gas: query")]

@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from 0d79ea1 to f81428a Compare January 5, 2026 08:48
meship-starkware
meship-starkware commented Jan 5, 2026
View reviewed changes
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 2 files.
Reviewable status: 2 of 9 files reviewed, 1 unresolved discussion (waiting on @avivg-starkware and @noaov1).

@meship-starkware meship-starkware changed the base branch from main to graphite-base/11410 January 20, 2026 07:09
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from f81428a to 72c94ff Compare January 20, 2026 07:09
@meship-starkware meship-starkware changed the base branch from graphite-base/11410 to meship/clean_get_execution_infos_test_cases January 20, 2026 07:09
@meship-starkware meship-starkware mentioned this pull request Jan 20, 2026
Merged
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch 2 times, most recently from 42c481e to 80c383c Compare January 20, 2026 07:55
@meship-starkware meship-starkware force-pushed the meship/clean_get_execution_infos_test_cases branch from d75157c to 9f8c3e6 Compare January 20, 2026 09:40
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from 80c383c to 0e204c5 Compare January 20, 2026 09:40
@meship-starkware meship-starkware force-pushed the meship/clean_get_execution_infos_test_cases branch from 9f8c3e6 to d33f5af Compare January 21, 2026 09:14
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from 0e204c5 to c301b49 Compare January 21, 2026 09:14
@meship-starkware meship-starkware force-pushed the meship/clean_get_execution_infos_test_cases branch from d33f5af to e301275 Compare January 21, 2026 12:26
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from c301b49 to 718611a Compare January 21, 2026 12:26
avivg-starkware
avivg-starkware approved these changes Jan 25, 2026
View reviewed changes
Copy link
Contributor

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@avivg-starkware reviewed 11 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1).

crates/blockifier/src/transaction/transactions_test.rs line 2641 at r4 (raw file):

        CairoVersion::Cairo1(RunnableCairo1::Casm),
    );
    let entry_point_selector = selector_from_name("test_get_execution_info_v3");

@noaov1 - I am leaning toward agreeing with @meshi of choosing to use _v3 instead of _v2 (here and in the other places using "test_get_execution_info") , WDYT?

Code quote:

"test_get_execution_info_v3"

@meship-starkware meship-starkware force-pushed the meship/clean_get_execution_infos_test_cases branch from e301275 to a926186 Compare January 25, 2026 14:54
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from 718611a to 944305b Compare January 25, 2026 14:54
@meship-starkware meship-starkware changed the base branch from meship/clean_get_execution_infos_test_cases to graphite-base/11410 January 26, 2026 07:00
@meship-starkware meship-starkware force-pushed the meship/add_test_get_execution_info_v2_to_test_contract branch from 944305b to 1a7d58e Compare January 26, 2026 07:00
@meship-starkware meship-starkware changed the base branch from graphite-base/11410 to main January 26, 2026 07:00
avivg-starkware
avivg-starkware approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@avivg-starkware avivg-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avivg-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1).

meship-starkware
meship-starkware commented Jan 26, 2026
View reviewed changes
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 11 files and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@meship-starkware meship-starkware added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 7db0d13 Jan 27, 2026
24 of 44 checks passed
@meship-starkware meship-starkware deleted the meship/add_test_get_execution_info_v2_to_test_contract branch January 27, 2026 08:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@avivg-starkware avivg-starkware avivg-starkware approved these changes

@noaov1 noaov1 Awaiting requested review from noaov1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meship-starkware @reviewable-StarkWare @avivg-starkware