perf: eliminate redundant allocations in bytecode_hash_node

[splinter012]

Refactored bytecode_hash_node nested node processing to compute results in a single pass.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[reviewable-StarkWare]

This change is 

[orizi]

@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @splinter012).

---

crates/cairo-lang-starknet-classes/src/casm_contract_class.rs line 209 at r1 (raw file):

            }
            let hash = H::hash_array(&hash_elements) + 1;
            (total_len, hash)

Suggestion:

            for node in nodes {
                let (len, hash) = bytecode_hash_node::<H>(iter, node);
                total_len += len;
                hash_elements.extend([len.into(), hash]);
            }
            (total_len, H::hash_array(&hash_elements) + 1)

[splinter012]

@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @splinter012).

crates/cairo-lang-starknet-classes/src/casm_contract_class.rs line 209 at r1 (raw file):

            }
            let hash = H::hash_array(&hash_elements) + 1;
            (total_len, hash)

Suggestion:

            for node in nodes {
                let (len, hash) = bytecode_hash_node::<H>(iter, node);
                total_len += len;
                hash_elements.extend([len.into(), hash]);
            }
            (total_len, H::hash_array(&hash_elements) + 1)

ready))