Skip to content

Conversation

@goldlinker
Copy link
Contributor

fix some minor issues in the comments

Signed-off-by: goldlinker <goldlinker@outlook.jp>
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @goldlinker).


crates/cairo-lang-defs/src/patcher.rs line 234 at r1 (raw file):

pub struct ModifiedNode<'db> {
    /// Children of the node.
    /// Can be None, in which case this is an empty node (of width 0). This is not the same as

this fix is wrong.
children if a None modified node can be modified (but do nothing). where children of an empty vec![] will not be found and will panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants