Skip to content

Conversation

@marukai67
Copy link
Contributor

Removes an unnecessary .clone() operation when creating PathBuf from test input, improving code efficiency and following Rust idioms.

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marukai67).

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marukai67).


crates/cairo-lang-starknet/src/plugin/test.rs line 129 at r1 (raw file):

        let contract_file_id = FileLongId::OnDisk(PathBuf::from(
            inputs["contract_file_name"].as_str(),
        ))

please do not open PRs without checking out and running the formatter.
if you cannot - will close PR.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @marukai67).


crates/cairo-lang-starknet/src/plugin/test.rs line 128 at r1 (raw file):

        let db = SHARED_DB_WITH_CONTRACTS.lock().unwrap().snapshot();
        let contract_file_id = FileLongId::OnDisk(PathBuf::from(
            inputs["contract_file_name"].as_str(),

Suggestion:

            &inputs["contract_file_name",

@marukai67
Copy link
Contributor Author

done

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @marukai67).


crates/cairo-lang-starknet/src/plugin/test.rs line 129 at r1 (raw file):

Previously, orizi wrote…

please do not open PRs without checking out and running the formatter.
if you cannot - will close PR.

locally run ./scripts/rust_fmt.sh before submitting. any response to this PR that does not include this will result in me closing it without further discussion.

@orizi
Copy link
Collaborator

orizi commented Feb 11, 2026

No response.
Closing.

@orizi orizi closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants