-
Notifications
You must be signed in to change notification settings - Fork 738
refactor: Remove redundant String clone in test runner #9609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @marukai67).
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marukai67).
crates/cairo-lang-starknet/src/plugin/test.rs line 129 at r1 (raw file):
let contract_file_id = FileLongId::OnDisk(PathBuf::from( inputs["contract_file_name"].as_str(), ))
please do not open PRs without checking out and running the formatter.
if you cannot - will close PR.
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @marukai67).
crates/cairo-lang-starknet/src/plugin/test.rs line 128 at r1 (raw file):
let db = SHARED_DB_WITH_CONTRACTS.lock().unwrap().snapshot(); let contract_file_id = FileLongId::OnDisk(PathBuf::from( inputs["contract_file_name"].as_str(),
Suggestion:
&inputs["contract_file_name",|
done |
orizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @marukai67).
crates/cairo-lang-starknet/src/plugin/test.rs line 129 at r1 (raw file):
Previously, orizi wrote…
please do not open PRs without checking out and running the formatter.
if you cannot - will close PR.
locally run ./scripts/rust_fmt.sh before submitting. any response to this PR that does not include this will result in me closing it without further discussion.
|
No response. |
Removes an unnecessary .clone() operation when creating PathBuf from test input, improving code efficiency and following Rust idioms.