(feat): moving reboxing to dataflow analysis #9585
Draft
+105
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
eytan-starkware
changed the base branch from
eytan_graphite/_feat_creating_forward_analysis_for_the_dataflow_framework
to
graphite-base/9585
eytan-starkware
force-pushed
the
eytan_graphite/_feat_moving_reboxing_to_dataflow_analysis
branch
from
a09ccda to
6bf1268
Compare
eytan-starkware
force-pushed
the
graphite-base/9585
branch
from
1c3949e to
b2daf3d
Compare
eytan-starkware
changed the base branch from
graphite-base/9585
to
eytan_graphite/_feat_creating_forward_analysis_for_the_dataflow_framework
5 tasks
eytan-starkware
changed the base branch from
eytan_graphite/_feat_creating_forward_analysis_for_the_dataflow_framework
to
graphite-base/9585
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the reboxing optimization to use the forward dataflow analysis framework instead of a manual block traversal approach. This change leverages the existing dataflow infrastructure to more systematically analyze variable usage patterns.
Type of change
Please check one:
Why is this change needed?
The previous implementation of reboxing candidate detection used a manual traversal approach that assumed a topological sort of blocks. By refactoring to use the forward dataflow analysis framework, we gain a more structured and maintainable approach to tracking variable state through the control flow graph.
What was the behavior or documentation before?
The reboxing optimization used a manual approach to track variable states across blocks, which was less structured and potentially more error-prone.
What is the behavior or documentation after?
The optimization now uses the forward dataflow analysis framework, which provides a more systematic approach to tracking variable states. The functionality remains the same, but the implementation is more maintainable and follows the established pattern for other dataflow analyses in the codebase.
Additional context
This refactoring maintains the same optimization behavior while improving the code structure. The test results show that the same reboxing candidates are identified, just in a slightly different order due to how the dataflow analysis traverses the blocks.