performance(sierra-to-casm): Removed CellExpression unrequired clone.

[orizi]

Summary

Refactored the CasmBuilder to improve handling of cell expressions by:

1. Splitting value retrieval into get_unadjusted and get_adjusted methods
2. Removing the adjust_ap boolean parameter in favor of explicit method names
3. Fixing potential overflow issues in offset calculations by using to_i16() and checked_add
4. Optimizing cell reference handling by applying AP changes more consistently

---

Type of change

Please check one:

• Performance improvement
• Bug fix (fixes incorrect behavior)
• New feature
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

---

Why is this change needed?

The current implementation of CasmBuilder has inconsistent handling of AP adjustments and cell references. The boolean adjust_ap parameter creates confusion about when adjustments should be applied. Additionally, the offset calculations for cell references could potentially overflow without proper checking.

---

What was the behavior or documentation before?

The code used a boolean parameter adjust_ap to determine whether to apply AP changes, leading to potential inconsistencies. Cell reference handling was also less efficient, with redundant cloning operations and unsafe offset calculations.

---

What is the behavior or documentation after?

The code now has explicit methods for adjusted and unadjusted values, making the intent clearer. Offset calculations use proper checked arithmetic to prevent overflows, and AP changes are applied more consistently throughout the codebase.

---

Additional context

This refactoring improves code maintainability by making the API more explicit about when AP adjustments are applied. It also reduces unnecessary cloning of cell expressions and adds proper bounds checking for offsets.

[orizi]

• performance(sierra-gas): Smaller equivalent costs map. #9535
• performance(sierra-gas): Added unchecked initialization, improving runtime marginally. #9529
• refactor(vec-map): Removed dependency on vec map totally. #9528
• performance(utils): By hand implementation of small-ordered-map. #9527
• performance(sierra-to-casm): Removed CellExpression unrequired clone. #9526 👈 (View in Graphite)
• Improve sierra debug info serde. #9525
• refactor(utils): Simplified serde implementation of map and set wrappers. #9519
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[TomerStarkware]

@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @orizi).

---

crates/cairo-lang-casm/src/builder.rs line 280 at r1 (raw file):

    pub fn assert_vars_eq(&mut self, dst: Var, res: Var, kind: AssertEqKind) {
        let a = self.as_adjasted_cell_ref(dst);
        let b = self.get_adjusted(res);

shouldn't this be unadjusted?

[orizi]

@orizi made 1 comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware).

---

crates/cairo-lang-casm/src/builder.rs line 280 at r1 (raw file):

Previously, TomerStarkware wrote…

shouldn't this be unadjusted?

if i do - we require to 'readjust' as well. attepted.

[TomerStarkware]

@TomerStarkware reviewed 1 file, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware).

[TomerStarkware]

@TomerStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @eytan-starkware).