Skip to content

Conversation

@orizi
Copy link
Collaborator

@orizi orizi commented Jan 14, 2026

Summary

Added the mimalloc feature flag to the Cairo test runner in the CI workflow to improve memory allocation performance.


Type of change

Please check one:

  • Bug fix (fixes incorrect behavior)
  • New feature
  • Performance improvement
  • Documentation change with concrete technical impact
  • Style, wording, formatting, or typo-only change

Why is this change needed?

The Cairo test runner can benefit from using the mimalloc memory allocator, which generally provides better performance characteristics than the default system allocator. This change enables the mimalloc feature in CI, which should result in faster test execution and potentially reduced memory usage.


What was the behavior or documentation before?

Previously, the CI workflow was running Cairo tests without the mimalloc allocator:

cargo run --profile=ci-dev --bin cairo-test -- ${{ matrix.cmd }}

What is the behavior or documentation after?

Now the CI workflow runs Cairo tests with the mimalloc allocator enabled:

cargo run --profile=ci-dev --bin cairo-test --features=mimalloc -- ${{ matrix.cmd }}

Additional context

Mimalloc is a compact general purpose allocator with excellent performance characteristics. This change should help improve CI performance without affecting test behavior.

@orizi orizi requested a review from eytan-starkware January 14, 2026 13:43
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

orizi commented Jan 14, 2026

Copy link
Contributor

@eytan-starkware eytan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@eytan-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi).

@orizi orizi changed the base branch from orizi/01-14-performance_cairo-execute_removed_mimalloc_dependency_preventing_workspace-level_feature_unification_ to graphite-base/9478 January 14, 2026 15:47
@orizi orizi force-pushed the graphite-base/9478 branch from e791abd to 3b7a44e Compare January 14, 2026 15:47
@orizi orizi force-pushed the orizi/01-14-performance_tests_using_the_mimalloc_feature_for_cairo-test_on_testing branch from 63fd003 to c186167 Compare January 14, 2026 15:47
@orizi orizi changed the base branch from graphite-base/9478 to main January 14, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants