Update laplace _tol functions for allow_fallthrough argument, tuple of control params#1586
Merged
Update laplace _tol functions for allow_fallthrough argument, tuple of control params#1586
Conversation
…f control parameters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 90.49% 90.50% +0.01%
==========================================
Files 65 65
Lines 9985 9997 +12
==========================================
+ Hits 9036 9048 +12
Misses 949 949
🚀 New features to boost your workflow:
|
Member
Author
|
@SteveBronder the codegen here is triggering those static asserts in the new laplace code: I think that the code there just needs to be okay accepting references, since the tuple is created with |
4 tasks
SteveBronder
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For stan-dev/math#3250
Submission Checklist
Release notes
Updated laplace _tol versions to accept control parameters as a tuple rather than a long list of trailing arguments.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)