Skip to content

ROX-32886: Add support for branding#52

Merged
mtodor merged 1 commit intomainfrom
mtodor/ROX-32886-add-support-for-branding
Mar 16, 2026
Merged

ROX-32886: Add support for branding#52
mtodor merged 1 commit intomainfrom
mtodor/ROX-32886-add-support-for-branding

Conversation

@mtodor
Copy link
Collaborator

@mtodor mtodor commented Mar 13, 2026

Description

This PR adds support for MCP server branding.

Changes:

  • added support for server and product name
  • consolidated all -X ldflags in config package
  • fixed Dockerfile to pass flag properly
  • added product name to each tool description

Validation

  • unit tests

@mtodor mtodor requested a review from janisz as a code owner March 13, 2026 12:29
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (03fc8af) to head (b3e6931).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   78.37%   78.49%   +0.12%     
==========================================
  Files          27       28       +1     
  Lines        1216     1223       +7     
==========================================
+ Hits          953      960       +7     
  Misses        223      223              
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

E2E Test Results

Commit: b3e6931
Workflow Run: View Details

=== Evaluation Summary ===

  ✓ list-clusters (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ cve-detected-clusters (assertions: 3/3)
  ~ cve-nonexistent (assertions: 2/3)
      - MaxToolCalls: Too many tool calls: expected <= 3, got 5
  ✓ cve-cluster-does-exist (assertions: 3/3)
  ~ cve-cluster-does-not-exist (assertions: 2/3)
      - ToolsUsed: Required tool not called: server=stackrox-mcp, tool=, pattern=list_clusters
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ~ rhsa-not-supported (assertions: 1/2)
      - MaxToolCalls: Too many tool calls: expected <= 1, got 3

Tasks:      11/11 passed (100.00%)
Assertions: 29/32 passed (90.62%)
Agent used tokens:
  Input:  33731 tokens
  Output: 22150 tokens
Judge used tokens:
  Input:  9150 tokens
  Output: 13546 tokens

@mtodor mtodor merged commit 18d456a into main Mar 16, 2026
6 checks passed
@mtodor mtodor deleted the mtodor/ROX-32886-add-support-for-branding branch March 16, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants