Merged
Conversation
janisz
commented
Mar 2, 2026
- Fix unused loop variable warnings in shell scripts by using underscore - Fix codecov action parameter (file -> files) for v5 compatibility Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive linting for shell scripts and GitHub Actions workflows to improve code quality and catch issues early. - Add shellcheck configuration (.shellcheckrc) with external sources enabled - Add actionlint for GitHub Actions workflow validation - Create make targets for shell-lint and actionlint - Integrate both linters into CI style workflow - Add documentation for code style checks and shell script guidelines - Add actionlint as a versioned Go tool dependency The project now has linting coverage for: - Go code (golangci-lint) - Shell scripts (shellcheck) - GitHub Actions workflows (actionlint) - Dockerfiles (hadolint) - Helm charts (kube-linter) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Apply shellcheck recommendations across all shell scripts: - Use braces around all variable references (SC2250) - Replace [ ] with [[ ]] for conditional tests (SC2292) - Add double quotes around variables in comparisons (SC2248) This ensures all scripts follow modern Bash best practices and pass shellcheck validation without warnings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> # Conflicts: # e2e-tests/scripts/run-tests.sh
Add comments explaining why SC2317 and SC2310 are false positives: - SC2317: cleanup() is invoked via trap, not directly - SC2310: || true pattern is intentional for test runner Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Group multiple echo redirects into a single command block and properly quote $GITHUB_STEP_SUMMARY to address shellcheck warnings SC2129 and SC2086. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
E2E Test ResultsCommit: a2806af |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 27 27
Lines 1216 1216
=======================================
Hits 953 953
Misses 223 223
Partials 40 40 ☔ View full report in Codecov by Sentry. |
Address shellcheck warnings SC2086 and SC2129 by quoting all variable references and grouping multiple redirects to the same file. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
mtodor
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added shellcheck and actionlint