Conversation
mtodor
left a comment
There was a problem hiding this comment.
One thing, I'm not sure is - will this work with passthrough auth type?
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> # Conflicts: # internal/server/server.go
9df8950 to
c5d4804
Compare
❌ 2 Tests Failed:
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Good point. Let me add e2e tests and whoami command as the part of startup |
There was a problem hiding this comment.
I have tested this, and it doesn't work with the passthrough auth flow. What is understandable because there are no request headers for stdio (I guess).
Anyway, it works for a static auth flow. Command looks like this:
claude mcp add --transport stdio test3 \
--env STACKROX_MCP__SERVER__TYPE=stdio \
--env STACKROX_MCP__CENTRAL__AUTH_TYPE=static \
--env STACKROX_MCP__CENTRAL__API_TOKEN="${ROX_TOKEN}" \
--env STACKROX_MCP__TOOLS__CONFIG_MANAGER__ENABLED=true \
--env STACKROX_MCP__CENTRAL__URL=staging.demo.stackrox.com:443 \
-- $PWD/stackrox-mcp
Let's make the following changes:
- document command in the readme (how to use
stdio) - add config validation if
stdiois used, the auth type has to bestatic
P.S. You can use the config manager tool because that one actually makes requests to the server. And you can create API token on staging demo and test everything against it.
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Add documentation for the stdio transport option based on PR feedback: - Add server.type configuration option to Server Configuration table - Document stdio transport usage with Claude Code CLI - Clarify that stdio requires static authentication (passthrough not supported) - Update HTTP-specific options to note they only apply to HTTP transport 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mtodor
left a comment
There was a problem hiding this comment.
Nice work! Added a few nitpicks, nothing related to the functionality.
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
- Renamed TestLoadConfig_ValidationPass to TestLoadConfig_ServerTypeValidationPass - Renamed validYAMLInvalidConfig variable to validYAMLConfig - Added TestValidate_ServerType_InvalidType to verify invalid server type validation - Fixed grammar in error message assertion (does require vs does requires) - Added auth_type: static to test config to satisfy stdio validation requirements Addresses feedback from https://github.com/stackrox/stackrox-mcp/pull/12/changes#r2602119520 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Description
This PR adds a configuration option to run
stdiomode.Validation
I run
and then asked to list cluster cves and got a valid error: