feat: Split +Inf overflow alerts by label-set#5
Merged
Conversation
Emit one RED/YELLOW result per offending histogram series (labels in title), keep one GREEN summary per metric, and render HELP as Metric description before Message for clearer triage. AI-generated: evaluator/report/template/TUI/test updates. User-provided/corrected: output contract (title format, section order, green-collapsing rule).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+Infoverflow alerts were hard to act on because they only reported the base histogram metric, not the specific label combinations causing the overflow. In practice, one problematic series was hidden among many label variants, so operators could not quickly identify the offending path.For example, the issue in:
was being reported as an issue with
however, the metric file contained over 1k lines for the metric
rox_central_k8s_event_processing_duration_countand the particular set of labels was difficult to find.We fixed this by evaluating histogram series per label-set and changing reporting behavior:
<metric>{...labels...} (+Inf overflow check)Metric descriptionbeforeMessagein markdown/console/TUI.This makes overflow alerts actionable (exact offending series is visible) without adding noise when metrics are healthy.
Moreover, we will now try to guess the histogram unit based on the metric name and the help text.