Open
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
porridge
approved these changes
Mar 17, 2026
cmd/junit2jira/main.go
Outdated
Comment on lines
+819
to
+822
| buildIDText := tc.BuildId | ||
| if buildIDText == "" { | ||
| buildIDText = " " // Use space for empty values to ensure text field is present, required by the API | ||
| } |
There was a problem hiding this comment.
Looks like we could create a func spaceIfEmpty(string) or similar, and avoid these kinds of blocks everywhere.
cmd/junit2jira/main.go
Outdated
|
|
||
| func render(tc j2jTestCase, text string) (string, error) { | ||
| tmpl, err := template.New("test").Funcs(map[string]any{"truncate": truncate, "truncateSummary": truncateSummary}).Parse(text) | ||
| tmpl, err := template.New("test").Funcs(map[string]interface{}{"truncate": truncate, "truncateSummary": truncateSummary}).Parse(text) |
There was a problem hiding this comment.
Curious why this change was needed? Isn't it the same these days?
Collaborator
Author
There was a problem hiding this comment.
Nope, it's not required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27
Tested: