refactor: go version #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinkim
requested review from
0xmhha,
code0xff,
egonspace,
eomti-wm and
hominlee-wemade
Co-authored-by: Felix Lange <fjl@twurst.com>
Replace manual byte-by-byte XOR implementation with the optimized bitutil.XORBytes function. This improves performance by using word-sized operations on supported architectures while maintaining the same functionality. The optimized version processes data in bulk rather than one byte at a time --------- Co-authored-by: Felix Lange <fjl@twurst.com>
egonspace
approved these changes
Jan 16, 2026
Contributor
|
For reference, go-ethereum's PR #28946 (Go 1.22 upgrade) includes some additional changes that could improve this PR:
Using |
Contributor
|
Per golangci-lint#4273, v1.55.2 does not support Go 1.22. Upgrade to v1.56.0+ is required |
Contributor
Author
|
Updated the PR with the following changes:
|
Contributor
Author
|
Resolved. I applied the upgrade to v1.59.0 via cherry-pick from upstream. Link |
0xmhha
requested changes
Jan 16, 2026
Member
0xmhha
left a comment
0xmhha
left a comment
There was a problem hiding this comment.
- change checksum :
build/checksums.txt -> need to update Go 1.21.6 → Go 1.22.x checksums
- README.md:237 -> need to change Go version 1.19 → "1.21 or later"
Member
|
Use `github.com/decred/dcrd/dcrec/secp256k1/v4` directly rather than `github.com/btcsuite/btcd/btcec/v2` which is just a wrapper around the underlying decred library. Inspired by cosmos/cosmos-sdk#15018 `github.com/btcsuite/btcd/btcec/v2` has a very annoying breaking change when upgrading from `v2.3.3` to `v2.3.4`. The easiest way to workaround this is to just remove the wrapper. Would be very nice if you could backport this to the release branches. References: - btcsuite/btcd#2221 - cometbft/cometbft#4294 - cometbft/cometbft#3728 - zeta-chain/node#2934
Contributor
Author
|
Updated the PR with the following changes:
|
Member
|
@colinkim |
Contributor
Author
|
Updated the PR with the following changes:
|
egonspace
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the Go toolchain version and updates related dependencies.
As part of the upgrade, additional CGO-based stress and concurrency tests
were added for
blstto ensure safety and correctness under parallel workloads.Changes
github.com/fjl/memsize/memsizeuidependencyblstTests
The following tests were executed to validate correctness and stability
after the Go version upgrade:
go test ./...)go test -race ./...)blststress and concurrency testsNotes
blsttests are intended to catch potential race conditionsor non-deterministic behavior introduced by CGO interactions or
Go runtime changes.
safety guarantees and test coverage.