Fix HTTP status mapping for client request errors#1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotADirectorypath misses as 404 so requests that descend into files return not found instead of internal server errorError cases and returned HTTP status
application/x-www-form-urlencodedparse failures: preserve the Actix response status, which is a client error for malformed inputmultipart/form-datarequest initialization failures: preserve the Actix response status, typically400 Bad Requestor415 Unsupported Media Type400 Bad Request,413 Payload Too Large, or500 Internal Server Errorfor tempfile I/O failuresContent-Disposition:400 Bad Request400 Bad RequestNotFoundandNotADirectorymisses during route existence checks, metadata reads, and file reads:404 Not FoundPermissionDeniedduring route existence checks, metadata reads, and file reads:403 Forbiddensafe_local_path:403 Forbiddensrc/webserver/error.rs:ErrorWithStatusis honored directly andsqlx::Error::PoolTimedOutremains429 Too Many RequestsTesting