Add timeout to OIDC HTTP response body read#1232
Merged
Conversation
A stalled OIDC provider that sends HTTP headers but never completes the body would cause response.body().await to hang forever, freezing the entire SQLPage process. Add a 5-second timeout on the body stream read using awc's ClientResponse::timeout(). Fixes #1231 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the Notify synchronization and yield_now() calls. Instead, use a small real-time sleep for TCP to complete, then pause+advance tokio time. Assert the actual response status instead of is_finished(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 5s timeout on OIDC HTTP response body reads. Without this, a provider that sends headers but stalls the body causes
response.body().awaitto hang forever, freezing all requests.Fixes #1231