refactor: replace misleading $quoteTransfer variable names with generic $abstractTransfer to reflect abstract transfer usage#1
Closed
greinerdavid wants to merge 1 commit intospryker:masterfrom
Conversation
Collaborator
|
Dear contributor, Your pull request will be reviewed by our team. In the meantime, please ensure that the PR complies with Spryker's coding guidelines and that your changes are covered by tests. Thank you very much for your contribution to the development of Spryker and the growth of the Spryker community! |
…ic $abstractTransfer to reflect abstract transfer usage
9074246 to
be61daa
Compare
Contributor
|
Released in https://github.com/spryker/step-engine/releases/tag/3.7.0. Could you please close the PR. |
Author
|
@matweew thank you very much. I closed the pr now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
AbstractTransfers are used in the spryker/step-engine package, which are a $quoteTransfer according to the annotation and variable name. This leads to misunderstandings and links the step engine to the checkout. However, as the step engine can also be used for other multi-step forms (wizards) independently of the checkout, it should not be linked to the checkout in the wording.
Steps before you submit a PR
contribution-license-agreement.txtfile with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/step-engine/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCHis a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist