Conversation
| export { Arc } from './arc.js'; | ||
| export { GreatCircle } from './great-circle.js'; | ||
| export { roundCoords, D2R, R2D } from './utils.js'; | ||
| export { _LineString } from './line-string.js'; |
There was a problem hiding this comment.
based on the filename, i'm guessing that it'd be preferable to stop exporting _LineString publicly.
There was a problem hiding this comment.
since the package.json has a files whitelist, i'm pretty sure the .npmignore blacklist is irrelevant/redundant.
| <button id="clear" class="btn">Clear All</button> | ||
| <button id="reset" class="btn btn-danger">Reset View</button> |
There was a problem hiding this comment.
since modules avoid polluting the global scope, we have to wire up the click handlers slightly differently.
|
|
||
| <script> | ||
| <script type="module"> | ||
| import { GreatCircle } from 'https://cdn.skypack.dev/arc@1'; |
There was a problem hiding this comment.
this won't work until we actually publish v1.0.0.
in the interim, either of the two below should work:
import { GreatCircle } from 'https://cdn.skypack.dev/-/arc@v1.0.0-beta.1';
import { GreatCircle } from './dist/index.js';
|
Alright, @jgravois as far as I can tell, the ESM module only pattern is working but we have a problem still with the great circle regression. I tested I've added a comment on #71 and opened up a new issue to investigate #75. |
I'd assume the same problem exists in regardless, I'll merge this and hold off on publishing until after we make a decision on #75 |
3 participants
as originally suggested in #34 (comment)
@thomas-hervey can you take v1.0.0-beta.1 for a spin in turf and let me know if you run into any problems?