Get Jira Issues action and Update PR description action #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klismannsm
requested changes
Jul 3, 2024
klismannsm
left a comment
klismannsm
left a comment
There was a problem hiding this comment.
Two general issues to address:
-
node_modules was not ignored. Did you add them to speed up the CI process?
-
The code is using semi-colons at the end of lines in almost every line, but some lines are not. We should choose one style and stick with it, possibly adding a prettier config file to handle this.
lib/update-pr-description.js
Outdated
Comment on lines
34
to
43
| const matchRegex = new RegExp(matchRegexString, 'g'); | ||
| let newDescription | ||
| console.log("Checking for matching content using regex:", matchRegex) | ||
| if (matchRegexString === undefined || !matchRegex.test(currentDescription)) { | ||
| console.log("No matching content found, adding new contents to the end") | ||
| newDescription = `${currentDescription}\n\n${newContents}`; | ||
| } else { | ||
| console.log("Matching content found, replacing it with new contents") | ||
| newDescription = currentDescription.replace(matchRegex, newContents); | ||
| } |
There was a problem hiding this comment.
(improvement): This can be extracted into a separated method to improve readability.
Contributor
Author
I will address other code comments in line with GitHub reviews |
klismannsm
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new GitHub actions
get-jira-issues: obtains a list of Jira issues for the specified projects from the commit messagesupdate-pr-description: updates a specified set of content in the PR description for easy updates of content such as the list of jira issues on a release PR