Skip to content

Fixup JdbcIndexedSessionRepository - multiple sessions for ID #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MFAshby wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Fixup JdbcIndexedSessionRepository - multiple sessions for ID #3638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ion-jdbc/src/main/java/org/springframework/session/jdbc/JdbcIndexedSessionRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,9 @@ public JdbcSession findById(final String id) {
if (sessions.isEmpty()) {
return null;
}
if (sessions.size() > 1) {
logger.warn("Found " + sessions.size() + " sessions for id " + id + ". Returning the first one.");
}
return sessions.get(0);
});

Expand Down Expand Up @@ -982,13 +985,13 @@ public List<JdbcSession> extractData(ResultSet rs) throws SQLException, DataAcce
delegate.setLastAccessedTime(Instant.ofEpochMilli(rs.getLong("LAST_ACCESS_TIME")));
delegate.setMaxInactiveInterval(Duration.ofSeconds(rs.getInt("MAX_INACTIVE_INTERVAL")));
session = new JdbcSession(delegate, primaryKey, false);
sessions.add(session);
}
String attributeName = rs.getString("ATTRIBUTE_NAME");
if (attributeName != null) {
byte[] bytes = getLobHandler().getBlobAsBytes(rs, "ATTRIBUTE_BYTES");
session.delegate.setAttribute(attributeName, lazily(() -> deserialize(bytes)));
}
sessions.add(session);
}
return sessions;
}
Expand Down