Skip to content

Fix compiler warnings in spring-security-acl #18626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dasog94 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compiler warnings in spring-security-acl #18626

dasog94 wants to merge 1 commit into from
+13 −9

Conversation

@dasog94
Copy link

@dasog94 dasog94 commented Jan 31, 2026 •
edited
Loading

  • Use asSubclass() in AclClassIdUtils to avoid a unchecked cast warning
  • Replace raw Map type with Map unbounded wildcard to avoid raw type warnings
  • Use ArgumentMatchers to avoid a unchecked cast warning
  • Suppress an unavoidable unchecked warning in reflection-based test code

Closes gh-18413

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 31, 2026
@dasog94 dasog94 marked this pull request as ready for review January 31, 2026 16:51
@rwinch rwinch self-assigned this Feb 2, 2026
@rwinch rwinch added in: acl An issue in spring-security-acl in: build An issue in the build type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 2, 2026
@rwinch rwinch enabled auto-merge (rebase) February 2, 2026 19:37
@rwinch rwinch added this to the 7.1.0-M2 milestone Feb 2, 2026
@rwinch
Copy link
Member

rwinch commented Feb 2, 2026

Thanks for the PR @dasog94! This will be merged one the PR build succeeds

@rwinch
Fix compiler warnings in spring-security-acl
9269c9e 
- Use asSubclass() in AclClassIdUtils to avoid a unchecked cast warning
- Replace raw Map type with Map<?, ?> unbounded wildcard to avoid raw type warnings
- Use ArgumentMatchers to avoid a unchecked cast warning
- Suppress an unavoidable unchecked warning in reflection-based test code

Closes spring-projectsgh-18413

Signed-off-by: Bae Jihong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rwinch rwinch

Labels

in: acl An issue in spring-security-acl in: build An issue in the build type: enhancement A general enhancement

Projects

None yet

Milestone

7.1.0-M2

Development

Successfully merging this pull request may close these issues.

Remove compiler warnings for spring-security-acl

3 participants

@dasog94 @rwinch @spring-projects-issues