Fix session concurrency for OAuth2/OIDC authentication #18624
+75
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Gautam-aman
force-pushed
the
fix-session-registry-authentication-key
branch
from
45d5308 to
11a6216
Compare
Signed-off-by: Aman Gautam <[email protected]>
rwinch
force-pushed
the
fix-session-registry-authentication-key
branch
from
11a6216 to
8fee53b
Compare
Member
|
FYI I rebased based off origin/main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Session concurrency control relies on principal equality when resolving
existing sessions. For OAuth2/OIDC logins, the principal is typically an
Authenticationwhose underlying principal (e.g.DefaultOidcUser)uses attribute-based equality.
Since attributes such as
nonce,jti, andsiddiffer per authentication,session lookups fail and
maximumSessionsbecomes ineffective.Approach
When the principal is an
Authentication, this change keys session registryentries by
Authentication#getName(), which represents the stable useridentity in Spring Security.
Existing behavior is preserved for non-Authentication principals.
Tests
Adds a regression test demonstrating correct session resolution when using
distinct
Authenticationinstances with the same name.