Remove compiler warnings in spring-security-data #18580
Open
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add compile-warnings-error plugin to data module - Remove deprecated setDefaultRolePrefix() call in getRootObject() - Add @SuppressWarnings deprecation for tests using deprecated methods - Add tests using AuthorizationManagerFactory Closes spring-projectsgh-18422 Signed-off-by: pocj8ur4in <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: build
rwinch
requested changes
Jan 26, 2026
Member
rwinch
left a comment
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've added some feedback inline
| root.setPermissionEvaluator(this.permissionEvaluator); | ||
| if (!DEFAULT_ROLE_PREFIX.equals(this.defaultRolePrefix)) { | ||
| // Ensure SecurityExpressionRoot can strip the custom role prefix | ||
| root.setDefaultRolePrefix(this.defaultRolePrefix); |
Member
There was a problem hiding this comment.
This is a breaking change. We must preserve this functionality until the deprecation has been removed. Can you please restore that?
rwinch
added
the
status: waiting-for-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test
./gradlew --no-build-cache clean :spring-security-data:check./gradlew formatCloses gh-18422