Fix gh-18565: Support consent for clients with no registered scopes #18574
+45
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses gh-18565, where the
OAuth2AuthorizationConsentAuthenticationProviderincorrectly handles authorization consent for aRegisteredClientwith no registered scopes.When
requireAuthorizationConsent(true)is set for a client with no scopes, the provider currently:ACCESS_DENIEDerror because it assumes an empty authority set implies user denial.IllegalArgumentExceptionfromOAuth2AuthorizationConsent.Builderbecause building with an empty authority set is not permitted.Changes
ACCESS_DENIEDifrequestedScopesis not empty.OAuth2AuthorizationConsent.Builder.build()only whenauthoritiesare present.Related Issue
Ref: gh-18565
How to Test
I have added a reproduction test case:
authenticateWhenNoScopesAndConsentRequiredThenReturnAuthorizationCode()inOAuth2AuthorizationConsentAuthenticationProviderTests.