GH-3618: Support CommonErrorHandler for suspend functions#4254
Open
zooo-code wants to merge 1 commit intospring-projects:mainfrom
Open
GH-3618: Support CommonErrorHandler for suspend functions#4254zooo-code wants to merge 1 commit intospring-projects:mainfrom
zooo-code wants to merge 1 commit intospring-projects:mainfrom
Conversation
Fixes spring-projectsGH-3618(spring-projects#3618) * Setup async failure callback when CommonErrorHandler is explicitly configured * Add test for suspend function with CommonErrorHandler Signed-off-by: zoo-code <kyj20908@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-3618(#3618)
Summary
Support
CommonErrorHandler(e.g.,DefaultErrorHandler) for Kotlin suspend functions.Previously, exceptions from suspend functions were only logged and not propagated to
CommonErrorHandler. This change sets up the async failure callback forRecordMessagingMessageListenerAdapterwhenCommonErrorHandleris explicitly configured.Changes
CommonErrorHandleris explicitly configuredCommonErrorHandlerinEnableKafkaKotlinCoroutinesTests.ktRelated
Thanks!!
Please let me know if any changes are needed. I'm happy to address any feedback promptly.