Fix embedded path ColumnInfo access for composite IDs (GH-2201)#2219
Closed
62hoon99 wants to merge 4 commits intospring-projects:mainfrom
Closed
Fix embedded path ColumnInfo access for composite IDs (GH-2201)#221962hoon99 wants to merge 4 commits intospring-projects:mainfrom
62hoon99 wants to merge 4 commits intospring-projects:mainfrom
Conversation
…sGH-2201) Signed-off-by: 62hoon99 <ske06008@gmail.com>
Closes spring-projects#2220 (cherry picked from commit 0fb03a1)
We now allow returning null values if a conversion of a simple value yields null. Closes spring-projects#2217 (cherry picked from commit e892849)
Fix nullability issues. See spring-projects#2217 (cherry picked from commit 08c86dc)
Author
|
Recreated this PR from a clean branch to fix history/CI issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
IllegalArgumentException: Cannot obtain ColumnInfo for embedded pathwhen using class-based composite IDs as@Idproperties.Problem
When
ResolvingRelationalPropertyValueProviderresolves identifiers for entities with composite IDs, it delegates toDocumentValueProvider.getValue()for embedded paths.Embedded paths do not have a single
ColumnInfo, which results in anIllegalArgumentException.Solution
Update
DocumentValueProviderto properly handle embedded paths:getValue(): returnnullfor embedded paths (values are resolved via individual properties)hasValue()/hasNonEmptyValue(): recursively evaluate embedded propertiesChanges
MappingRelationalConverter.DocumentValueProviderto handle embedded paths correctlyResolvingRelationalPropertyValueProviderbehaviorTesting
All tests pass. Both class-based and record-based composite IDs are now handled correctly.
Fixes #2201
Checklist