Fix EndpointRequest.toLinks() not matching when base-path is '/'#49253
Closed
apoorvdarshan wants to merge 3288 commits intospring-projects:3.5.xfrom
Closed
Fix EndpointRequest.toLinks() not matching when base-path is '/'#49253apoorvdarshan wants to merge 3288 commits intospring-projects:3.5.xfrom
apoorvdarshan wants to merge 3288 commits intospring-projects:3.5.xfrom
Conversation
In addition to the upgrade, this commit also fixes some contract violations in non-public APIs that are now detected as the new version of the plugin enables contract checking by default. Closes spring-projectsgh-49000
…ecordExporterBuilder See spring-projectsgh-49002 Signed-off-by: Joaquin Santana <joaquinjsb@outlook.com>
…GrpcLogRecordExporterBuilder" See spring-projectsgh-49002
* pr/49002: Polish "Add customizers for OtlpHttpLogRecordExporterBuilder and OtlpGrpcLogRecordExporterBuilder" Add customizers for OtlpHttpLogRecordExporterBuilder and OtlpGrpcLogRecordExporterBuilder Closes spring-projectsgh-49002
Prior to this commit, the `XmlMapper` auto-configuration for Jackson2 would refer to Jackson3's `XmlMapper` instead of Jackson2. This would not only make the condition invalid, but it could also lead to `NoClassDefFoundError` at runtime if the application mixed Jackson 2 and 3 on the classpath. Fixes spring-projectsgh-49015
Update `RestClientAutoConfiguration` to ensure that it applies after `HttpMessageConvertersAutoConfiguration`. Prior to this commit, the `HttpMessageConvertersRestClientCustomizer` bean might not get created due to the `@ConditionalOnBean` guard not finding any `ClientHttpMessageConvertersCustomizer` beans. Since the issue is surprising hard to replicate in a unit test, a new smoke test has been added to ensure the problem doesn't return. Fixes spring-projectsgh-49223
When management.endpoints.web.base-path is set to "/", cleanBasePath() stripped it to "", making LinksRequestMatcher return EMPTY_MATCHER (always false). Preserve "/" as a valid base path and avoid producing "//" patterns in link matchers. Fixes spring-projectsgh-34834 Signed-off-by: Apoorv Darshan <ad13dtu@gmail.com>
apoorvdarshan
force-pushed
the
fix/endpoint-request-tolinks-root-basepath
branch
from
c25a9c2 to
51a7a86
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks, but we already have a PR open for this that I'd like to review first (see #49191) |
philwebb
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
management.endpoints.web.base-pathis set to"/",cleanBasePath()stripped it to"", causingLinksRequestMatcherto returnEMPTY_MATCHER(always false)"/"as a valid base path inWebEndpointProperties.cleanBasePath()by only stripping trailing/from paths longer than 1 character"//"patterns in servlet and reactive link matchers when basePath already ends with/Fixes gh-34834