Add the full vault path to the PropertySource.

[tstenner]

This allows clients to use properties from multiple vault sources that end in the same key, e.g. foo/bar/application and bar/baz/application.

Without this change, composite vault sources can't have the same key (application name, profile, …):

spring.cloud.config.server.composite:
  - type: vault
    # ...
    backend: vault/path/a
  - type: vault
    # ...
    backend: vault/path/a

{
 "name": "app-name",
  "profiles": [
    "default",
    "some-profile"
  ],
  "propertySources": [
   {
      "name": "vault:some-profile",
      "source": {
        "spring.datasource.username": "some-application"
        "hello": "from /vault/path/a/some-profile"
      }
    },
    {
      "name": "vault:some-profile",
      "source": {
        "hello": "from /vault/path/b/some-profile"
      }
    }
  ]
}

With this patch, the source name contains the full name (e.g. vault:path/b/some-profile) similar to the yaml sources (e.g. /root/path/app/application.yaml).

[ryanjbaxter]

Can you add some tests that validate this fix?

[tstenner]

The existing tests already cover it (that's why they are failing). I'll add another commit with the adjusted tests tomorrow.

[ryanjbaxter]

I am a bit concerned about changing the name in a minor release because if someone is relying on the current schema this may break them. One thought I had would be to only change the name when there are multiple vault environment repositories configured so we fix the conflict, but leave the existing behavior in tact for every other case.

[tstenner]

Absolutely. In retrospect, submitting this PR a few months earlier would've solved this nicely.

Your suggestion is still a change for some users (i.e. those who have distinct keys in multiple vault sources), but there it is more likely they actually want the fixed behaviour.

As a migration path I could image adding a flag to include the full vault path (off by default) and change the default in the next major release. This would make the implementation simpler and fully backwards-compatible.

[tstenner]

I added a fullKeyPath property (defaulting to false) to the vault property source.
The previous behaviour as checked by the unit tests is unchanged and the new behaviour is checked by a new unit test.

[ryanjbaxter]

Thats fine, but we need documentation on the property and why someone would use it.

[tstenner]

Added in 9d48794