Ensure property-defined Vault token is used when auth is TOKEN #3178
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: johnycho <[email protected]>
|
@johnycho Wow! Respecting the explicitly configured token when authentication=TOKEN is set aligns much better with expected behavior, and the added unit test strengthens confidence in the change. I hope this gets merged :) |
Contributor
|
Thank you. In the future please be sure to run the full build before submitting the PR to catch errors like this 11e1d45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
SpringVaultTemplateBuilderignored the configured static token ifspring.cloud.config.server.vault.authenticationwas explicitly set toTOKEN. This caused the application to incorrectly fall back to default authentication mechanisms (e.g., filesystem token) even when a token was provided in the properties.This change updates the
isStaticTokenpredicate to returntruewhen a token is present and the authentication method is eithernull(default) or explicitly set toTOKEN.A unit test has been added to ensure the default
ConfigTokenProvideris ignored in this scenario.Fixes gh-3172