Skip to content

Conversation

@asears
Copy link

@asears asears commented Jan 4, 2026

  • Configure line length to 120
  • Configure the project to allow formatting with ruff, ufmt, black
  • Format files with the various formatters
  • Exclude 2 files which are causing conflicts with ruff formatter

Copy link
Member

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like CI isn't happy with the line limit increase. I'd personally keep it as-is TBH, but you can also feel free to fix CI to use the increased limit and that's fine by me too!

@asears asears marked this pull request as ready for review January 21, 2026 00:50
@asears
Copy link
Author

asears commented Jan 21, 2026

Decreased to 120 to match the tox.ini settings and reran ruff.

Could move the setup.py and tox.ini settings to pyproject.toml in another pr if that makes sense.

@sea-bass
Copy link
Member

sea-bass commented Feb 8, 2026

Sorry for the delay, I don't really check this repo unless tagged/requested for review.

Seems like some CI is failing, but otherwise good! One thing I will say is we don't need to run all 3 formatters. If ruff meets all the needs, for example, then we could remove the other 2.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants