fix: Restore keyboard navigation in category and currency selectors #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap command items in CommandList instead of a plain div to restore arrow key navigation in the category and currency dropdown selectors. The cmdk library requires CommandList (CommandPrimitive.List) to handle keyboard events for navigating between items with Up/Down arrow keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My navigation for entering expenses used to be possible using just Tab and Up/Down Arrow Keys; searching for the Category and then choosing the right one with the arrow keys. This broke recently, this PR restores keyboard navigation (Up/Down arrow keys) in category and currency selector dropdowns.
The category and currency selectors use the https://github.com/dip/cmdk library for searchable command menus, according to the examples items should be wrapped in Command.List. The selectors were using a plain