Draft
Conversation
Member
|
Need to drop PHP <8.4 |
Author
Updated. |
roxblnfk
reviewed
Mar 5, 2026
Member
|
Are you going to add something or we can merge it? |
Author
@roxblnfk I've tested updating https://github.com/spiral/framework to use this branch, and the tests fail miserably. I've been holding back because I've been trying to determine if the test failures are due to breaking changes going from phpunit 10 > 13 or because of an issue with these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
PHPUnit\Framework\TestCase::invokeTestMethodinstead ofPHPUnit\Framework\TestCase::runTestWhy?
Many current versions of great testing tools/libraries (such as Pest) will not work with the current spiral/testing package due to it being pinned to an old version of PHPUnit.
Checklist