Improve logging around reading and merging config files#2106
Open
chancez wants to merge 1 commit intospf13:masterfrom
Open
Improve logging around reading and merging config files#2106chancez wants to merge 1 commit intospf13:masterfrom
chancez wants to merge 1 commit intospf13:masterfrom
Conversation
Currently viper logs at info level when it attempts to read or merge a config file, and then logs the file it is reading at debug level. When reading multiple files, this means we only get redundant log messages about attempts, but no details about what files are actually being read unless we use debug logs. This patch swaps the log levels so that we get info logs about what files are being read, and debug logs about the attempts. Signed-off-by: Chance Zibolski <chancez@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently viper logs at info level when it attempts to read or merge a config file, and then logs the file it is reading at debug level. When reading multiple files, this means we only get redundant log messages about attempts, but no details about what files are actually being read unless we use debug logs. This patch swaps the log levels so that we get info logs about what files are being read, and debug logs about the attempts.