feat: add WriteConfigAsTyped with authomatic type coercion Fixed #202…#2053
Open
danrulev wants to merge 1 commit intospf13:masterfrom
Open
feat: add WriteConfigAsTyped with authomatic type coercion Fixed #202…#2053danrulev wants to merge 1 commit intospf13:masterfrom
danrulev wants to merge 1 commit intospf13:masterfrom
Conversation
…3#2021 Co-authored-by Daniel danilRulv22@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
WriteConfigAsTypedandSafeWriteConfigAsTypedto write configuration with proper types instead of strings. This is especially useful when config values come from sources that only provide strings — like environment variables or CLI flags.Without this, Viper writes
"true"instead oftrue,"42"instead of42, etc. This PR fixes that by automatically coercing types before writing.Example
Before
After
Changes
✅ WriteConfigAsTyped(filename) — writes config with type coercion
✅ SafeWriteConfigAsTyped(filename) — same, but fails if file exists
✅ Recursive coercion in nested maps and slices
✅ Handles bool, int64, float64 from string representations
✅ Full test coverage for JSON, YAML, TOML
Test Plan
TestWriteConfigAsTyped — covers all formats
TestSafeWriteConfigAsTyped — checks file existence
Correct type conversion
Notes
Integers are parsed as int64 for better TOML/YAML output (no .0)
Uses existing Viper patterns: afero, logger, encoderRegistry