type hint: Make Optional explicit (PEP 484) #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 484 prohibits implicit Optional. Note that this mass conversion is done automatically by https://github.com/hauntsaninja/no_implicit_optional as suggested by mypy, with a human review. Uses `... | None` style instead of `Optional[...]` since we are now using Python 3.10. Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 484 prohibits implicit Optional.
https://peps.python.org/pep-0484/#union-types
This PR updates type hints from:
to
Note that this mass conversion is done automatically by https://github.com/hauntsaninja/no_implicit_optional as suggested by mypy, with a human review.
Uses
... | Nonestyle instead ofOptional[...]since we are now using Python 3.10.