Skip to content

Conversation

@kmorel
Copy link
Contributor

@kmorel kmorel commented Jan 2, 2026

Also update the patches so that they get applied to the previous version (1.5) but not this one (as they are already applied).

@vicentebolea
Copy link
Member

There seems to be some build failures in the mgard CUDA job

@kmorel
Copy link
Contributor Author

kmorel commented Jan 6, 2026

There seems to be some build failures in the mgard CUDA job

Thanks for pointing this out, @vicentebolea. There was an issue with MGARD and recent versions of protobuf on CUDA. I've submitted a PR to MGARD to fix this. I've added the patch from that PR, and now at checks pass.

Are we now ready to go?

Also update the patches so that they get applied to the previous version
(1.5) but not this one (as they are already applied).
Copy link
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Ken

@alalazo alalazo self-assigned this Jan 7, 2026
@alalazo alalazo merged commit b27990c into spack:develop Jan 7, 2026
17 checks passed
@kmorel kmorel deleted the mgard-1-6-0 branch January 7, 2026 13:42
@kmorel
Copy link
Contributor Author

kmorel commented Jan 7, 2026

Thanks for the merge, @alalazo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants