p4est: add explicit -lm to fix link failures with newer toolchains #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some example targets (e.g. v4l2) use math functions such as sin(), but libm was not listed explicitly on the link line. Older toolchains linked this transitively, but newer GCC/binutils reject this with “DSO missing from command line”. Add -lm explicitly to make the link robust and portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some example targets (e.g. v4l2) use math functions such as sin(), but libm was not listed explicitly on the link line. Older toolchains linked this transitively, but newer GCC/binutils reject this with “DSO missing from command line”. Add -lm explicitly to make the link robust and portable.
This should also fix this issue.