Update train.py #157
Open
Update train.py #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the use of patience for early stopping
Owner
|
Hello @danielvalencia95 I think the command line argument already employs a default value of 10 for early stopping. I think the change you made might not be necessary. Please let me know if I am missing something. |
Author
|
Hello @sovit-123 the default value works, but with a different values the early stopping don´t work. Also, i made another PR for the eval.py |
Owner
|
That's a bit odd. I will surely test it out and if necessary will merge your code. |
Author
|
Hello @sovit-123 Ok, please also review my PR about eval.py |
Owner
|
Will do that, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the use of patience for early stopping