gitindex: fall back when cat-file filter is unsupported#1037
Draft
keegancsmith wants to merge 1 commit intomainfrom
Draft
gitindex: fall back when cat-file filter is unsupported#1037keegancsmith wants to merge 1 commit intomainfrom
keegancsmith wants to merge 1 commit intomainfrom
Conversation
Older Git versions can reject cat-file --batch with --filter, causing the process to exit before yielding any blobs. We were treating the closed stdout pipe as EOF, which made indexing silently produce empty shards. Capture cat-file stderr and wait status so startup failures surface as real errors. If cat-file fails before any blobs are processed, fall back to the existing go-git path so indexing still succeeds on older Git installations. Keep mid-stream cat-file failures fatal instead of falling back once some blobs have already been indexed. That avoids mixing two readers and writing partial or inconsistent shards.
Member
Author
|
Note: I haven't tested this code yet, so just opening as a draft PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older Git versions can reject cat-file --batch with --filter, causing the process to exit before yielding any blobs. We were treating the closed stdout pipe as EOF, which made indexing silently produce empty shards.
Capture cat-file stderr and wait status so startup failures surface as real errors. If cat-file fails before any blobs are processed, fall back to the existing go-git path so indexing still succeeds on older Git installations.
Keep mid-stream cat-file failures fatal instead of falling back once some blobs have already been indexed. That avoids mixing two readers and writing partial or inconsistent shards.