Skip to content

all: we no longer support -1 for pagination #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keegancsmith merged 2 commits into from
Apr 8, 2026
+4 −19
Merged

all: we no longer support -1 for pagination #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac95dcf
all: we no longer support -1 for pagination
keegancsmith Apr 8, 2026
7dba86a
Merge branch 'main' into k/list--1
keegancsmith Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions cmd/src/extsvc_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Examples:
fmt.Println(usage)
}
var (
firstFlag = flagSet.Int("first", -1, "Return only the first n external services. (use -1 for unlimited)")
firstFlag = flagSet.Int("first", 1000, "Return only the first n external services.")
formatFlag = flagSet.String("f", "", `Format for the output, using the syntax of Go package text/template. (e.g. "{{.|json}}")`)
apiFlags = api.NewFlags(flagSet)
)
Expand All @@ -40,9 +40,6 @@ Examples:
}

first := *firstFlag
if first == -1 {
first = 9999999 // GraphQL API doesn't support negative for unlimited query
}

var formatStr string
if *formatFlag != "" {
Expand Down
6 changes: 1 addition & 5 deletions cmd/src/orgs_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ Examples:

$ src orgs list

List *all* organizations (may be slow!):

$ src orgs list -first='-1'

List organizations whose names match the query:

$ src orgs list -query='myquery'
Expand All @@ -33,7 +29,7 @@ Examples:
fmt.Println(usage)
}
var (
firstFlag = flagSet.Int("first", 1000, "Returns the first n organizations from the list. (use -1 for unlimited)")
firstFlag = flagSet.Int("first", 1000, "Returns the first n organizations from the list.")
queryFlag = flagSet.String("query", "", `Returns organizations whose names match the query. (e.g. "alice")`)
formatFlag = flagSet.String("f", "{{.Name}}", `Format for the output, using the syntax of Go package text/template. (e.g. "{{.ID}}: {{.Name}} ({{.DisplayName}})" or "{{.|json}}")`)
apiFlags = api.NewFlags(flagSet)
Expand Down
6 changes: 1 addition & 5 deletions cmd/src/repos_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,6 @@ Examples:

$ src repos list -f '{{.|json}}'

List *all* repositories (may be slow!):

$ src repos list -first='-1'

List repositories whose names match the query:

$ src repos list -query='myquery'
Expand All @@ -182,7 +178,7 @@ Examples:
fmt.Println(usage)
}
var (
firstFlag = flagSet.Int("first", 1000, "Returns the first n repositories from the list. (use -1 for unlimited)")
firstFlag = flagSet.Int("first", 1000, "Returns the first n repositories from the list.")
queryFlag = flagSet.String("query", "", `Returns repositories whose names match the query. (e.g. "myorg/")`)
// TODO: add support for "names" field.
clonedFlag = flagSet.Bool("cloned", true, "Include cloned repositories.")
Expand Down
6 changes: 1 addition & 5 deletions cmd/src/users_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ Examples:

$ src users list

List *all* users (may be slow!):

$ src users list -first='-1'

List users whose names match the query:

$ src users list -query='myquery'
Expand All @@ -37,7 +33,7 @@ Examples:
fmt.Println(usage)
}
var (
firstFlag = flagSet.Int("first", 1000, "Returns the first n users from the list. (use -1 for unlimited)")
firstFlag = flagSet.Int("first", 1000, "Returns the first n users from the list.")
queryFlag = flagSet.String("query", "", `Returns users whose names match the query. (e.g. "alice")`)
tagFlag = flagSet.String("tag", "", `Returns users with the given tag.`)
formatFlag = flagSet.String("f", "{{.Username}}", `Format for the output, using the syntax of Go package text/template. (e.g. "{{.ID}}: {{.Username}} ({{.DisplayName}})" or "{{.|json}}")`)
Expand Down
Loading