feat: allow symbol navigation buttons to open in new tab#1079
Closed
feat: allow symbol navigation buttons to open in new tab#1079
Conversation
- Add createBrowsePath to useBrowseNavigation hook to generate URLs - Update LoadingButton component to support asChild prop for anchor elements - Convert symbol hover popup buttons to use anchor elements with href - Users can now cmd+click (ctrl+click) to open definitions/references in new tab Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
- Replace anchor elements with Next.js Link components for proper Cmd+click (Mac) / Ctrl+click (Windows) support to open in new tabs - Revert LoadingButton asChild changes since we now use Link directly - Buttons now properly support native browser behavior for opening links Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables users to open code navigation buttons ("Go to definition" and "Find references") in a new tab by using Cmd+click (Mac) or Ctrl+click (Windows/Linux).
Changes
useBrowseNavigation.ts: AddedcreateBrowsePathfunction that returns the URL path without navigating, allowing components to use it as anhrefattributesymbolHoverPopup/index.tsx:Linkcomponents for proper Cmd+click / Ctrl+click supportgotoDefinitionHrefandfindReferencesHrefmemos to compute the navigation URLsLinkwith button stylingLoadingButtononClickhandlerHow it works
The buttons now render as Next.js
Linkcomponents with the navigation URL in thehrefprop. Next.js Link components natively support modifier key clicks:This works in both the file browser (
/browse) and in Ask sessions when hovering over symbols in code citations.Fixes #847
Linear Issue: SOU-847