Skip to content

Conversation

@spacecostsmoney
Copy link
Contributor

Made a new configuration var in AWS Dev.

Turns out we can just pass channelId or name into the call this is already using. https://docs.slack.dev/reference/methods/chat.postMessage/

Will need an admin to add this in prod before merging!

@spacecostsmoney spacecostsmoney self-assigned this Oct 29, 2025
@spacecostsmoney
Copy link
Contributor Author

spacecostsmoney commented Oct 29, 2025

image

I'm not planning to fix the badge generation as that's not important for this :)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Slack integration to use channel IDs instead of channel names when posting messages. According to the Slack API documentation, the chat.postMessage method accepts either channel IDs or names, so this change maintains compatibility while moving to a more explicit identifier.

Key Changes:

  • Renamed configuration parameter from SlackChannel to SlackChannelId
  • Updated all function parameters from channelName to channelId throughout the codebase
  • Updated documentation to reflect the use of channel IDs

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
template.yaml Renamed CloudFormation parameter from SlackChannel to SlackChannelId with updated description
src/index.js Updated environment variable reference from SlackChannel to SlackChannelId
src/slack-service.js Renamed function parameters from channelName to channelId
src/slack.js Renamed function parameter from channelName to channelId
test/index.test.js Updated test variable and environment variable names to use slackChannelId
README.md Updated documentation to reference channel ID instead of channel name

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spacecostsmoney spacecostsmoney merged commit 2bc6019 into main Oct 29, 2025
1 of 2 checks passed
@spacecostsmoney spacecostsmoney deleted the use-slack-channel-id branch October 29, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants