adapt styles to source.coop #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adapts the application's styling to match the source.coop design system by migrating from hardcoded color values to a consistent CSS variable system and updating dependencies to their latest versions.
Key changes include:
- Replaced hardcoded hex colors (#ddd, #eee, #444, etc.) with CSS custom properties (var(--gray-X)) for consistent theming
- Updated hightable theming from generic variable names to specific semantic names (e.g., --menu-color, --header-background-color)
- Upgraded key dependencies: hightable (0.20.2 → 0.25.0), hyparquet (1.20.0 → 1.23.3), and hyperparam (0.3.25 → 0.4.2)
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/index.css | Removed unused CSS rules (sub, duplicate overlay), replaced hardcoded colors with CSS variables, changed overlay from fixed to absolute positioning, and reorganized code for better structure |
| src/styles/hightable.css | Completely refactored theme variables from generic naming (--hy-color-X) to semantic naming (--menu-color, --header-background-color, etc.), added nested CSS rules for thead/tbody styling |
| src/styles/colors.css | Added new color variables (--gray-a11, --accent-2) with support for both light and dark color schemes |
| package.json | Updated three dependencies to newer versions and indirectly added squirreling as a transitive dependency |
| package-lock.json | Updated lockfile to reflect new dependency versions and added squirreling package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Deployed. LightBefore 
After 
DarkBefore 
After 
|
Contributor
Author
|
cc @jedsundwall : I applied the same style changes as in the CSV table (the one you approved + two more: source-cooperative/csv-table#36 and source-cooperative/csv-table#38) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17
Same as source-cooperative/csv-table#35 + source-cooperative/csv-table#36 + source-cooperative/csv-table#38.