fix incoherence at the end of the table #31
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an incoherency issue that occurs at the end of a CSV table when the last cached range ends at EOF (end of file). The fix ensures that row numbers in the final range are snapped to match the estimated total number of rows, but only during data retrieval (display), not during row fetching operations.
Key Changes:
- Added
snapEOFToNumRowsparameter togetStatus()method to control when EOF snapping should be applied - Modified
getCell()to passsnapEOFToNumRows: true, enabling the fix for display scenarios - Implemented conditional logic to calculate accurate row positions when the last range ends at EOF
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the last range ends at EOF, snap the row numbers of its cells to the estimated number of rows. We do it only when showing the results (getCell), not when checking which rows to fetch, because it can lead to gaps between rows.