Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue that caused a test failure in chandra_limits. I added a test here, so one does not need to run the chandra_limits test to see it fail. This only addressed the case that failed in chandra_limits.
The issue is that
get_ocat_localuses the given arguments to assemble a query on the fly. The query is assembled in a loop:Since numpy 2, this format will create queries like
"seq_num=='np.str_('700958')'"instead of"seq_num=='700958'". This PR fixes that and it is backward compatible.I did grep on
!rand these are all the instances left:The first three are log messages. The last one is a test, and the inputs to the test are never numpy types.
As a side note, I did a search for
!rin the sot organization, and found that this format is used in log messages in several places. I can understand it if one wants to log the type of the variable, because sometimes an error happens due to a wrong type, but that is not the norm. Most times I prefer log messages to be more human readable.Interface impacts
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.