Skip to content

fix archive.cds.get_proposal_abstract #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taldcroft merged 2 commits into from
May 20, 2025
Merged

fix archive.cds.get_proposal_abstract #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bc870
fix archive.cds.get_proposal_abstract
javierggt May 16, 2025
db768f9
fix test
javierggt May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mica/archive/cda/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ def get_proposal_abstract(obsid=None, propnum=None, timeout=60):

html = _get_cda_service_text("prop_abstract", timeout=timeout, **params)
text = html_to_text(html)
text += "\nTEXT_END:"

# Return value is a text string with these section header lines. Use them
# to split the text into sections.
Expand All @@ -275,7 +276,7 @@ def get_proposal_abstract(obsid=None, propnum=None, timeout=60):
"Proposal Number",
"Principal Investigator",
"Abstract",
"",
"TEXT_END",
]
out = {}
for delim0, delim1 in zip(delims[:-1], delims[1:]):
Expand Down
3 changes: 2 additions & 1 deletion mica/archive/tests/test_cda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,8 @@ def test_get_proposal_abstract():
"ALMA. Chandra resolution & sensitivity enables the study of "
"large scale phenomena: (1) influence of the surrounding "
"environment; (2) interaction between galaxies; (3) influence of "
"groups and clusters"
"groups and clusters: (4) BH growth and census; (5) star formation "
"and stellar populations; (6) feedback from starbursts and AGNs."
),
"principal_investigator": "Martin Elvis",
"proposal_number": "08900073",
Expand Down