Skip to content

Conversation

@jeanconn
Copy link
Contributor

Description

Remove centroid dashboard/reports processing

Interface impacts

Testing

Unit tests

  • No unit tests
  • Linux
ska3-jeanconn-fido> git rev-parse HEAD
47b8ba30de8740479ba1bdfcd3bed6f3cba22cad
ska3-jeanconn-fido> pytest
========================================================== test session starts ===========================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 113 items                                                                                                                      

mica/archive/tests/test_aca_dark_cal.py ..................                                                                         [ 15%]
mica/archive/tests/test_aca_hdr3.py ..                                                                                             [ 17%]
mica/archive/tests/test_aca_l0.py .....                                                                                            [ 22%]
mica/archive/tests/test_asp_l1.py .......                                                                                          [ 28%]
mica/archive/tests/test_cda.py ..............................................                                                      [ 69%]
mica/archive/tests/test_obspar.py .                                                                                                [ 69%]
mica/report/tests/test_report.py ..                                                                                                [ 71%]
mica/report/tests/test_write_report.py .                                                                                           [ 72%]
mica/starcheck/tests/test_catalog_fetches.py ...............                                                                       [ 85%]
mica/stats/tests/test_acq_stats.py ...                                                                                             [ 88%]
mica/stats/tests/test_guide_stats.py ....                                                                                          [ 92%]
mica/vv/tests/test_vv.py .........                                                                                                 [100%]

============================================================ warnings summary

Though removing it just shows there weren't any unit tests of the dashboard / reports.

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn requested a review from Copilot April 30, 2025 12:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the centroid dashboard/report processing by deleting the update_centroid_reports.py script.

  • Removed the update_centroid_reports.py file which called mica.centroid_dashboard functions.
Files not reviewed (1)
  • task_schedule.cfg: Language not supported

@jeanconn jeanconn requested review from javierggt and taldcroft April 30, 2025 13:51
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@jeanconn jeanconn merged commit 68ae5c4 into master May 7, 2025
2 checks passed
@jeanconn jeanconn deleted the no-centroid-dashboard branch May 7, 2025 12:57
This was referenced Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants