Add new manvr_mon_images module

[taldcroft]

Description

This adds a new module chandra_aca.manvr_mon_images with a function read_manvr_mon_images. This reads data from the maneuver monitor window images archive over a date range, with optional handling for specifying the dark current scaling.

Requires

• Maneuver monitor images archive in $SKA/data/manvr_mon_images/. This is available on HEAD.

Interface impacts

None

Testing

Unit tests

• Mac

Test failures are unrelated, due to having an incomplete Aspect L1 archive on my laptop that does not include the data required for these tests.

(ska3) ➜  chandra_aca git:(manvr-mon-images) git rev-parse --short HEAD
e19d798
(ska3) ➜  chandra_aca git:(manvr-mon-images) pytest                    
======================================= test session starts =======================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/aldcroft/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 258 items                                                                               

chandra_aca/tests/test_aca_image.py .....................                                   [  8%]
chandra_aca/tests/test_all.py ........................                                      [ 17%]
chandra_aca/tests/test_attitude.py ........................................................ [ 39%]
.....                                                                                       [ 41%]
chandra_aca/tests/test_dark_model.py ............                                           [ 45%]
chandra_aca/tests/test_dark_subtract.py .........                                           [ 49%]
chandra_aca/tests/test_drift.py ..............................................              [ 67%]
chandra_aca/tests/test_manvr_mon_images.py .......                                          [ 67%]
chandra_aca/tests/test_maude_decom.py .........................                             [ 77%]
chandra_aca/tests/test_planets.py .................                                         [ 84%]
chandra_aca/tests/test_psf.py ...                                                           [ 85%]
chandra_aca/tests/test_residuals.py FF...                                                   [ 87%]
chandra_aca/tests/test_star_probs.py .................................                      [100%]

============================================ FAILURES =============================================

Independent check of unit tests by Jean

• Linux

(ska3-latest) jeanconn-kady> pytest
================================================= test session starts ==================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /proj/sot/ska/jeanproj/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 263 items                                                                                                    

chandra_aca/tests/test_aca_image.py .....................                                                        [  7%]
chandra_aca/tests/test_all.py ........................                                                           [ 17%]
chandra_aca/tests/test_attitude.py .............................................................                 [ 40%]
chandra_aca/tests/test_dark_model.py ............                                                                [ 44%]
chandra_aca/tests/test_dark_subtract.py .........                                                                [ 48%]
chandra_aca/tests/test_drift.py ..............................................                                   [ 65%]
chandra_aca/tests/test_manvr_mon_images.py .......                                                               [ 68%]
chandra_aca/tests/test_maude_decom.py .........................                                                  [ 77%]
chandra_aca/tests/test_planets.py .................                                                              [ 84%]
chandra_aca/tests/test_psf.py ...                                                                                [ 85%]
chandra_aca/tests/test_residuals.py .....                                                                        [ 87%]
chandra_aca/tests/test_star_probs.py .................................                                           [100%]

=================================================== warnings summary ===================================================
chandra_aca/chandra_aca/tests/test_planets.py::test_planet_positions
chandra_aca/chandra_aca/tests/test_planets.py::test_planet_positions
chandra_aca/chandra_aca/tests/test_planets.py::test_venus_position1[stk]
chandra_aca/chandra_aca/tests/test_planets.py::test_venus_position1[stk]
chandra_aca/chandra_aca/tests/test_planets.py::test_venus_position2[stk]
chandra_aca/chandra_aca/tests/test_planets.py::test_venus_position2[stk]
chandra_aca/chandra_aca/tests/test_residuals.py::test_multi_ai
chandra_aca/chandra_aca/tests/test_residuals.py::test_multi_ai
  /export/jeanconn/miniforge3/envs/ska3-latest/lib/python3.12/site-packages/bs4/builder/_lxml.py:124: DeprecationWarning: The 'strip_cdata' option of HTMLParser() has never done anything and will eventually be removed.
    parser = parser(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
===================================== 263 passed, 8 warnings in 124.12s (0:02:04) ======================================
(ska3-latest) jeanconn-kady> git rev-parse HEAD
e19d798eb714c8a9dbc7a7f6f3afd6c717e57c43

Functional tests

Substantial functional testing in read-manvr-mon-images.ipynb. The function here is very similar to the one in the notebook.

[taldcroft]

@jeanconn - I have addressed your comments, and made some improvements as well.

[taldcroft]

@jeanconn - ready for review again.

[jeanconn]

LGTM thanks!