-
Notifications
You must be signed in to change notification settings - Fork 259
SIMD-0401: Stake program Pinocchio migration (p-stake)
#401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I don't feel convinced by the motivation section. Are stake instructions really using up so much block space that we need to optimize them? This feels like a much smaller win compared to optimizing the token program. |
True, but perhaps the SIMD should have put the second point in the motivation section first. There is a no-std wave coming where there will be increasing requirements to adopt it else be marooned w/ old tooling. Alignment with the upstream eBPF toolchain is a primary goal for folks working on the compiler/VM. Aligning with this earlier will allow us to not build new features that eventually have to be re-written in no-std rust. A quite nice side effect of this work is the CU savings. |
|
Ok, I'm definitely out of the loop on no-std plans but that feels like something we can do later in favor of doing other things that are more impactful to developers now. |
|
lgtm |
p-stake)p-stake)
|
Hey @grod220, this PR has been inactive for 60 days and is now marked as stale. If you're still working on this, please comment below to let us know. Otherwise, this PR will be automatically closed in 7 days. To keep this PR active, simply leave a comment explaining the current status or any blockers you're facing. |
|
Bump. Related preliminary work still in progress: #391 |
|
Thanks for the update, @grod220! The stale label has been removed. This PR will no longer be automatically closed. |
Proposal to replace the current version of the Stake Program (
Stake11111111111111111111111111111111111111) with a CU-optimized Pinocchio version:p-stake.